-
Notifications
You must be signed in to change notification settings - Fork 68
Bump nixpkgs, flake, go to fix deprecated golang.org/x/crypto #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cafkafk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With passing CI, this seems sane to me 👍
Sorry, I'm an idiot, I just did a manual rebase on master and force pushed it, so now the CI is spinning again.. |
|
@cafkafk The flake check is very wonky on the current nixpkgs version I pinned to (the one based on nixos-24.11) - it seems like the nodejs version used actually just isn't cached on hydra for some reason or the other. |
@cafkafk ping |
- golang.org/x/crypto@v0.35.0 requires go >= 1.23.0 - go >= 1.23.0 requires nixpkgs 24.11
This PR replaces #256 since more work is required.
Fixes https://github.com/DBCDK/morph/security/dependabot/10
Bumping golang.org/x/crypto requires updating go to at least 1.23, but go 1.23 isn't in 24.05, so I'm taking this opportunity to also update our flake input of nixpkgs from
nixos-24.05tonixos-24.11, which is long overdue anyways. Maybe it should even be updated to unstable.This also bumps all go dependencies and runs tidy on them. There's also a bonus-fix to
.envrcto keep shellcheck happy.