Smaller subset of MinGW patches #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illwieckz
force-pushed
the
illwieckz/mingw-1
branch
from
cb36a17 to
e52b0bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from:
I removed the CPU detection patches that are much larger, so we can review those very small patches first. I also removed the
macamd64.inctrick that can be reviewed later.They are plenty of patches in this branch, but each ones are very simple.
This makes possible for @slipher to test that none of those patches are breaking MSVC Windows and Linux builds.
If none of those patches do break the standard builds supported by SCons, then we can merge them, even if we cannot build for MinGW yet.
To build for MinGW we would need the extra patches that are remaining in the
illwieckz/mingwbranch and the CMake toolchain.This can be merged before the CMake toolchain is merged.