Fix ClimateControl using hardcoded API_BASE_URL instead of vehicle base_url#203
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix hardcoded API_BASE_URL in climate control
Fix ClimateControl using hardcoded API_BASE_URL instead of vehicle base_url
Jun 11, 2026
DasBasti
approved these changes
Jun 11, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes Smart #5 (HY series) climate control failures by building the telematics endpoint URL from the selected vehicle’s resolved base_url (v1 vs v2) instead of the hardcoded API_BASE_URL, aligning ClimateControll with existing control patterns (e.g., charging control).
Changes:
- Remove the hardcoded
API_BASE_URLdependency from climate control. - Construct the telematics PUT URL using
self.account.vehicles[self.vin].base_urlso Smart #5 routes to the v2 host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Climate control commands fail on Smart #5 vehicles with error
8060: The vehicle corresponding to the VIN does not existbecauseClimateControluses hardcodedAPI_BASE_URL(v1) instead of the vehicle'sbase_url, which resolves toAPI_BASE_URL_V2for Smart #5 (HYseries).ChargingControlalready handles this correctly. This change alignsClimateControlwith that pattern: