Skip to content

fix(makefile): improve Lima local dev setup and fix open-dd dashboard URL#1044

Merged
aymericDD merged 1 commit intomainfrom
aymeric.daurelle/fix/open-dd
Feb 26, 2026
Merged

fix(makefile): improve Lima local dev setup and fix open-dd dashboard URL#1044
aymericDD merged 1 commit intomainfrom
aymeric.daurelle/fix/open-dd

Conversation

@aymericDD
Copy link
Contributor

@aymericDD aymericDD commented Feb 26, 2026

What does this PR do?

  • Fixes a bug

Fixes the open-dd Makefile target which was using an outdated Datadog infrastructure URL. Also improves the lima-install-datadog-agent target reliability by checking Helm release status, adding error suppression on idempotent operations, waiting for deployment readiness, and using dynamic cluster/host naming via envsubst. Adds .envrc to .gitignore.

Related to #969, which introduced the generic cluster name configuration for the Datadog agent.

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • Verified open-dd opens the correct Datadog infrastructure hosts page
    • Verified lima-install-datadog-agent completes idempotently
    • locally.
    • as a canary deployment to a cluster.

… URL

- Fix open-dd target to use updated Datadog infrastructure hosts URL format
- Check Helm release status instead of namespace in lima-install-datadog-agent
- Use envsubst to substitute LIMA_INSTANCE in datadog-agent.yaml
- Add kubectl wait for Datadog agent deployment readiness
- Use dynamic clusterName and set DD_HOSTNAME in datadog-agent.yaml
- Add .envrc to .gitignore
@aymericDD aymericDD force-pushed the aymeric.daurelle/fix/open-dd branch from 53b3605 to c0753f9 Compare February 26, 2026 09:57
@datadog-official
Copy link

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 39.29% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c0753f9 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@aymericDD aymericDD marked this pull request as ready for review February 26, 2026 10:08
@aymericDD aymericDD requested a review from a team as a code owner February 26, 2026 10:08
@aymericDD aymericDD merged commit 5e250fd into main Feb 26, 2026
13 checks passed
@aymericDD aymericDD deleted the aymeric.daurelle/fix/open-dd branch February 26, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants