Add autoscaling failover config to DatadogAgent CR#2723
Add autoscaling failover config to DatadogAgent CR#2723clamoriniere wants to merge 2 commits intomainfrom
Conversation
Co-authored-by: clamoriniere <cedric.lamoriniere@datadoghq.com>
|
I can only run on private repositories. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2723 +/- ##
=======================================
Coverage 38.81% 38.81%
=======================================
Files 308 308
Lines 26705 26707 +2
=======================================
+ Hits 10365 10367 +2
Misses 15561 15561
Partials 779 779
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
tbavelier
left a comment
There was a problem hiding this comment.
Discussing offline so "blocking" the PR until then: failover was already always enabled when configured with the operator. Metrics env var was only added on node Agent, not on DCA
|
Ok, when I checked that it was missing,it was indeed in the cluster-agent |
What does this PR do?
Adds a new
failover.enabledboolean option underspec.features.autoscaling.workloadin the DatadogAgent CR to control the autoscaling failover mechanism. When enabled (the default), the operator automatically setsDD_AUTOSCALING_FAILOVER_ENABLEDandDD_AUTOSCALING_FAILOVER_METRICSenvironment variables on the Cluster Agent and Node Agent components.Motivation
Previously, users who enabled workload autoscaling had to manually add
DD_AUTOSCALING_FAILOVER_ENABLEDenvironment variable overrides to bothclusterAgentandnodeAgentsections. This change makes failover a first-class configuration option that is enabled by default when workload autoscaling is active, removing the need for manual env var overrides.Additional Notes
The failover is enabled by default (
true) when workload autoscaling is enabled. Users can explicitly disable it:Minimum Agent Versions
Describe your test plan
go vetandgofmtcleanChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabelPR by Bits
View session in Datadog
Comment @DataDog to request changes