[MVP] feat: Add DatadogInstrument CRD and operator feature#2724
Draft
Mathew-Estafanous wants to merge 12 commits intomainfrom
Draft
[MVP] feat: Add DatadogInstrument CRD and operator feature#2724Mathew-Estafanous wants to merge 12 commits intomainfrom
Mathew-Estafanous wants to merge 12 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2724 +/- ##
==========================================
- Coverage 38.80% 38.57% -0.23%
==========================================
Files 308 310 +2
Lines 26703 27186 +483
==========================================
+ Hits 10363 10488 +125
- Misses 15561 15920 +359
+ Partials 779 778 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces the
DatadogInstrumentationCRD and an operator feature that provisions the infrastructure needed for the Cluster Agent to act on it.The CRD lets teams define Datadog integration checks for their workloads without modifying pod annotations or restarting agents:
The operator feature (
workload_config) handles:<dda-name>-crd-check-conf) with create-only semantics — the operator creates it but never overwrites it, so the Cluster Agent can freely write check configs into it.<config-path>/crd-conf.d/so the Agent picks up checks written by the Cluster Agent.get/list/watchondatadoginstrumentationandget/updateon the ConfigMap.Store:
AddOnlysemanticsA new
AddOnlymethod on the dependency store marks objects as create-only. DuringApply(), the store skips updates for these objects, preventing the operator's reconciliation loop from resetting externally-managed content.Motivation
Non-SRE teams need a way to configure Datadog monitoring for their workloads without touching pod annotations or coordinating agent restarts. The
DatadogInstrumentationCRD provides a Kubernetes-native interface for this. Thespec.configwrapper is designed to support additional features in future releases.Describe how you validated your changes
podcheck-crd) and verified:Additional Notes
DatadogWorkloadConfigresources and write resolved check configs into the ConfigMap in a separate change.ddwc).spec.selectorrequires at least one ofmatchLabelsormatchAnnotations(enforced by validation).