Enable agent auto-install in EKS add-on wrapper chart#2754
Enable agent auto-install in EKS add-on wrapper chart#2754gpalmz wants to merge 9 commits intoDataDog:mainfrom
Conversation
Configure the operator-eks-addon wrapper to enable the installAgents feature from the datadog-operator subchart, so agents are automatically deployed after the operator is installed via the EKS add-on. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2c05b9504
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The EKS add-on requires all images to be available in the Marketplace ECR. Using bitnami/kubectl from Docker Hub would cause ImagePullBackOff in private-cluster setups without egress. Also expose agentInstallJob image config in the AWS Marketplace schema so it can be overridden. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cc510a3b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
With installAgents defaulting to true, omitting the API key would pass schema validation but fail at hook runtime. Making apiKey required in the schema surfaces the error in the EKS console before installation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The wrapper still pins datadog-operator to 2.18.1 which does not have the installAgents feature. Bumping to 0.1.25 now would advertise a capability that the subchart cannot deliver. The version bump and version table entry should be added when the dependency is updated. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 059482fcc1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
marketplaces/charts/operator-eks-addon/aws_mp_configuration_schema.json
Outdated
Show resolved
Hide resolved
Draft-04 JSON Schema has no conditional required support, so this blocked operator-only deployments with installAgents=false. The subchart already validates at template time that an API key is set when installAgents is true. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
=======================================
Coverage 38.78% 38.78%
=======================================
Files 309 309
Lines 26839 26839
=======================================
Hits 10409 10409
Misses 15650 15650
Partials 780 780
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
All images must be pulled from the EKS Marketplace ECR at install time. Exposing the image repository in the schema would let users override it to an external registry, breaking private-cluster installs. The image is pinned in values.yaml and should not be user-configurable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The hook Job downloads the agent config at install time, which requires internet egress. Private/air-gapped EKS clusters would fail. This should not be user-configurable in the Marketplace; the helm-charts subchart needs to embed the default config instead of downloading it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The helm-charts PR was updated to embed the default agent config in a ConfigMap instead of downloading it at runtime. agentConfigUrl no longer exists in the subchart. Also updated README to reflect that the Job is no longer a Helm hook and config is bundled, not fetched. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…n-agent-auto-install
3 participants
Summary
installAgentsfeature in the operator-eks-addon wrapper chart so agents are automatically deployed after the EKS add-on installs the operatorinstallAgents,apiKey, andappKeyto the AWS Marketplace configuration schemaDetails
The
installAgentsfeature (Job, RBAC, ConfigMap templates) lives in thedatadog-operatorsubchart in helm-charts (DataDog/helm-charts#2476). This PR configures the EKS add-on wrapper to enable it by default:values.yaml
installAgents: true— agents install automaticallyagentInstallJob.image.repository— points to Marketplace ECR (709825985650.dkr.ecr.us-east-1.amazonaws.com/datadog/kubectl) instead of Docker Hub, since private/air-gapped EKS clusters may not have external egressaws_mp_configuration_schema.json
installAgents(boolean, default true) — exposed for EKS Console / CLI / CloudFormationapiKeyandappKey(strings) — credential fields for add-on configurationagentInstallJob.imageis intentionally not exposed — all install-time images must come from the Marketplace ECRapiKeyis intentionally not required at schema level — draft-04 JSON Schema has no conditional required, and the subchart already validates at template time wheninstallAgentsis trueREADME.md
crane copycommand for the kubectl image under "Pushing Container Images"No template duplication is needed — the wrapper passes values through to the subchart via Helm's dependency system.
Dependencies
datadog-operatordependency version and wrapper chart version need bumping once the subchart release is cutbitnami/kubectl:1.31must be copied to709825985650.dkr.ecr.us-east-1.amazonaws.com/datadog/kubectl:1.31Test plan
helm dependency buildinmarketplaces/charts/operator-eks-addon/helm template test . --set datadog-operator.apiKey=test123— verify agent-install Job, ConfigMap, RBAC, and operator Deployment all renderhelm template test . --set datadog-operator.apiKey=test123 --set datadog-operator.installAgents=false— verify no agent-install resourceshelm template test .(no apiKey) — verify template error about missing API key🤖 Generated with Claude Code