fix set non-empty applied condition reason for invalid profiles#2758
Open
ucpr wants to merge 1 commit intoDataDog:mainfrom
Open
fix set non-empty applied condition reason for invalid profiles#2758ucpr wants to merge 1 commit intoDataDog:mainfrom
ucpr wants to merge 1 commit intoDataDog:mainfrom
Conversation
Author
|
I don't have permission to add labels, so could you please add them for me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix empty reason field in DatadogAgentProfile status condition that causes Kubernetes API validation errors.
When a profile fails validation, the Applied condition was set with empty Reason and Message fields. Kubernetes requires reason to be at least 1 character, so the status update was rejected.
Motivation
The operator was logging the following error continuously:
This prevented profile status from being updated when validation failed.
Additional Notes
The fix sets Reason: "Invalid" and Message: "Profile is not valid" for the Applied condition when the profile is invalid, consistent with how other conditions use InvalidConditionReason to indicate the cause.
Minimum Agent Versions
N/A - operator-only change, no agent version requirement.
Describe your test plan
Confirmed that make test passes all tests.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel