Add error-tracking monitor option to DatadogMonitor CRD. #2775#2778
Open
AkselAllas wants to merge 1 commit intoDataDog:mainfrom
Open
Add error-tracking monitor option to DatadogMonitor CRD. #2775#2778AkselAllas wants to merge 1 commit intoDataDog:mainfrom
AkselAllas wants to merge 1 commit intoDataDog:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7e25f1612
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
c627456 to
64f680b
Compare
64f680b to
5fc510b
Compare
Author
|
I overwrote the DatadogMonitor CRD with the following file (Taken from my PR fork): datadoghq.com_datadogmonitors.yaml And by using the following image & conf for the operator: And this is the monitor yml diff: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Close #2775
Since the go api already supports error-tracking via
datadogV1.MONITORTYPE_ERROR_TRACKING_ALERT, then it's super easy to expose this via the CRD.Motivation
Get error-tracking monitors working via k8s yml.
#2775
Additional Notes
Need help with labels and commit signing. I signed it but it's not working 🤔
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Probably.
Describe your test plan
My fork successfully created the monitor in my k8s cluster.
I overwrote the DatadogMonitor CRD with the following file (Taken from my PR fork):
datadoghq.com_datadogmonitors.yaml
And by using the following image & conf for the operator:
And this is the monitor yml diff:
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel