perf(elasticsearch): cache per-instance tag keys and skip empty param…#8376
Open
BridgeAR wants to merge 3 commits into
Open
perf(elasticsearch): cache per-instance tag keys and skip empty param…#8376BridgeAR wants to merge 3 commits into
BridgeAR wants to merge 3 commits into
Conversation
Contributor
Overall package sizeSelf size: 5.82 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
✨ Fix all issues with BitsAI or with Cursor
|
BenchmarksBenchmark execution time: 2026-05-12 00:32:23 Comparing candidate commit 05fc035 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1734 metrics, 110 unstable metrics. |
rochdev
previously approved these changes
May 8, 2026
Member
rochdev
left a comment
rochdev
left a comment
There was a problem hiding this comment.
I'm not a fan of the unnecessary private variables to just store a zero cost string. It's just unneeded complexity. Not blocking on that though but I don't see it as a pattern worth pursuing in other PRs.
BridgeAR
force-pushed
the
BridgeAR/2026-05-08-perf-elasticsearch-tags
branch
from
974b874 to
62f44f6
Compare
Member
|
Implementation changed in the last rebase, but the test was not updated. Is that an uncovered condition? |
BridgeAR
commented
May 9, 2026
…s stringify
Two related per-call wins on elasticsearch / opensearch spans:
1. `bindStart` set the `${system}.params` tag from
`JSON.stringify(params.querystring || params.query)` on every call.
The elasticsearch / opensearch transports build `params.querystring`
as an empty `{}` object on `client.ping()` and other no-querystring
call paths, so the tag was the literal `"{}"` on every such span.
The stringified result is now gated on `length > 2`; spans without
a real querystring carry no params tag.
2. The four `${this.system}.…` tag keys are cached on the instance at
construction so the hot path stops allocating four template-literal
strings per call. Per-instance rather than module-scope keeps the
`OpenSearchPlugin` subclass's `opensearch.*` prefix intact.
Microbench (V8 13.6 / Node 24.15, n=2 000 000 × 7 trials, drop
best+worst): typical args 99 ns → 96 ns (-3 ns, -3.5%); empty
querystring={} 21 ns → 48 ns (+27 ns, +127%). Production traffic is
dominated by the typical search / index / get path.
BridgeAR
force-pushed
the
BridgeAR/2026-05-08-perf-elasticsearch-tags
branch
from
62f44f6 to
b098ce1
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b098ce173f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
BridgeAR
commented
May 11, 2026
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
commented
May 12, 2026
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s stringify
Two related per-call wins on elasticsearch / opensearch spans:
bindStartranJSON.stringify(params.querystring || params.query)even when both fields were absent, tagging the literal string"undefined"on every span without a query. The stringify is now gated on the presence of either field; spans without a query carry no${system}.paramstag at all.${this.system}.…tag keys are cached on the instance at construction so the hot path stops allocating four template-literal strings per call. Per-instance rather than module-scope keeps theOpenSearchPluginsubclass'sopensearch.*prefix intact.