BDMS-540: Link NMA_WeatherPhotos to NMA_WeatherData#470
Conversation
…NMA_WeatherPhotos via WeatherID - move weather_id under FK section and enforce NOT NULL - add FK + relationship + validator on NMA_WeatherPhotos - mark NMA_WeatherData.weather_id unique for FK target - run WeatherPhotos transfer after WeatherData and skip orphan photos - add migration to backfill/cleanup and enforce FK/NOT NULL - update legacy tests to create WeatherPhotos with a real parent WeatherData
ksmuczynski
requested review from
TylerAdamMartinez,
jacob-a-brown,
jirhiker and
kbighorse
|
My hope was that these types of changes would be taken care of in the db refactor and data transformation step that is to follow the 1:1 migration. Given we are so close to having migrated all the data I'd like to limit the modifications to the transfer script |
|
Okay, I will revisit this on Monday. |
|
Do you suggest a rollback on all changes? |
|
no, I think the only changes that potentially need to be rolled back are the changes to the transfer scripts. I think the outstanding question we all need to consider "is all the necessary data migrated from nma to ocotillo, for all models." The changes this PR makes seem like they could be accomplished without having to run a fresh transfer (?). Basically, I want to move away from the "wholesale transfer model" and move into the "DB refactor and data transformation model" introduced in PR #464 As I write this tho I remember that another transfer is required to get some previously orphaned chemistry data migrated. so Im going to approve this |
jirhiker
merged commit 830609d
into
kas-bdms-540-NMA_SurfaceWaterPhotos-FK-relationship
TylerAdamMartinez
deleted the
kas-bdms-540-NMA_WeatherPhotos-FK-relationship
branch
2 participants
Why
This PR addresses the following problem / context:
NMA_WeatherPhotoslacked a direct FK relationship toWeatherData, making joins and integrity checks harder.How
Implementation summary - the following was changed / added / removed:
WeatherIDFK relationship betweenNMA_WeatherPhotosandNMA_WeatherData.WeatherPhototransfer to use the new relationship and aligns transfer helpers.WeatherPhototests to cover theWeatherIDrelationship.Notes
Any special considerations, workarounds, or follow-up work to note?
- !! This is the last PR in the chain of "BDMS-540:..." PRs (467-469).