BDMS-609: Add support for legacy SiteNotes handling

core/lexicon.json

@@ -8206,6 +8206,13 @@
       "term": "OwnerComment",
       "definition": "Legacy owner comments field"
     },
+    {
+      "categories": [
+        "note_type"
+      ],
+      "term": "Site Notes (legacy)",
+      "definition": "Legacy site notes field from WaterLevels"
+    },
     {
       "categories": [
         "well_pump_type"

db/thing.py

@@ -434,6 +434,10 @@ def sampling_procedure_notes(self):
     def construction_notes(self):
         return self._get_notes("Construction")
 
+    @property
+    def site_notes(self):
+        return self._get_notes("Site Notes (legacy)")
+
     @property
     def well_status(self) -> str | None:
         """

schemas/thing.py

@@ -211,6 +211,7 @@ class BaseThingResponse(BaseResponseModel):
     monitoring_frequencies: list[MonitoringFrequencyResponse] = []
     general_notes: list[NoteResponse] = []
     sampling_procedure_notes: list[NoteResponse] = []
+    site_notes: list[NoteResponse] = []
 
     @field_validator("monitoring_frequencies", mode="before")
     def remove_records_with_end_date(cls, monitoring_frequencies):

transfers/waterlevels_transfer.py

@@ -33,6 +33,7 @@
     Contact,
     FieldEventParticipant,
     Parameter,
+    Notes,
 )
 from db.engine import session_ctx
 from transfers.transferer import Transferer
@@ -158,6 +159,7 @@ def _transfer_hook(self, session: Session) -> None:
             "observations_created": 0,
             "contacts_created": 0,
             "contacts_reused": 0,
+            "notes_created": 0,
         }
 
         gwd = self.cleaned_df.groupby(["PointID"])
@@ -396,6 +398,38 @@ def _transfer_hook(self, session: Session) -> None:
                     session.execute(insert(Observation), observation_rows)
                     stats["observations_created"] += len(observation_rows)
 
+                # Site Notes (legacy)
+                # If there are duplicate notes for a single point ID, we only create one note.
+                # However, if some duplicates are "time stamped" (meaning they are attached to
+                # rows with different dates), we should ideally preserve that context.
+                # The current implementation prepends the date to the note content
+                # to ensure that duplicate content from different dates remains distinct.
+                unique_notes: dict[str, datetime] = {}
+                for prep in prepared_rows:
+                    if hasattr(prep["row"], "SiteNotes") and prep["row"].SiteNotes:
+                        content = str(prep["row"].SiteNotes).strip()
+                        if content:
+                            dt = prep["dt_utc"]
+                            # We keep all notes that have different content OR different dates
+                            # Actually, if content is same but date is different, we want to see it.
+                            # So we key by (content, date)
+                            key = (content, dt.date())
+                            if key not in unique_notes:
+                                unique_notes[key] = dt
+
+                for (content, _), dt in unique_notes.items():
+                    date_prefix = dt.strftime("%Y-%m-%d")
+                    session.add(
+                        Notes(
+                            target_table="thing",
+                            target_id=thing_id,
+                            note_type="Site Notes (legacy)",
+                            content=f"{date_prefix}: {content}",
+                            release_status="public",
+                        )
+                    )
+                    stats["notes_created"] += 1
+
                 session.commit()
                 session.expunge_all()
                 stats["groups_processed"] += 1