`test(features): enforce lexicon values for water-level descriptor fields#583
Merged
ksmuczynski merged 1 commit intostagingfrom Mar 4, 2026
Merged
`test(features): enforce lexicon values for water-level descriptor fields#583ksmuczynski merged 1 commit intostagingfrom
ksmuczynski merged 1 commit intostagingfrom
Conversation
…elds - Update water-level CSV feature to require lexicon-valid values (when provided) for: - sample_method - level_status - data_quality - Replace free-text acceptance scenario with negative validation scenario for invalid lexicon values - Keep failure expectations consistent: non-zero exit, field/row validation errors, and no imports`
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the water-level CSV bulk-upload BDD spec to require lexicon-constrained values for water-level descriptor fields, replacing prior free-text acceptance expectations.
Changes:
- Added a happy-path requirement stating
sample_method,level_status, anddata_qualitymust be lexicon-valid when provided. - Replaced the free-text acceptance scenario with a negative validation scenario for invalid lexicon values.
ksmuczynski
approved these changes
Mar 4, 2026
Contributor
ksmuczynski
left a comment
There was a problem hiding this comment.
Looks great, approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
water-level-csv.featurestill allowed free-text behavior wheresample_method,level_status, anddata_qualityshould be enum/lexicon-constrained.How
Implementation summary - the following was changed / added / removed:
tests/features/water-level-csv.featureonly.sample_method,level_status, anddata_qualitymust be valid lexicon values.Notes
Any special considerations, workarounds, or follow-up work to note?