Skip to content

feat: implement dynamic loading of pygeoapi app and improve description formatting#617

Merged
jirhiker merged 3 commits intostagingfrom
fix-ogc-mounting
Mar 25, 2026
Merged

feat: implement dynamic loading of pygeoapi app and improve description formatting#617
jirhiker merged 3 commits intostagingfrom
fix-ogc-mounting

Conversation

@jirhiker
Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Use bullet points here

How

Implementation summary - the following was changed / added / removed:

  • Use bullet points here

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

Copilot AI review requested due to automatic review settings March 25, 2026 21:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the pygeoapi mounting integration to dynamically (re)load the pygeoapi.starlette_app module at mount time, and cleans up a handful of long strings/comments for improved formatting consistency.

Changes:

  • Added _load_pygeoapi_app() to import or reload pygeoapi.starlette_app and return its APP for mounting.
  • Updated mount_pygeoapi() to use the dynamic loader instead of a direct import.
  • Reformatted several long description strings and a few long comments/error messages for readability.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
core/pygeoapi.py Introduces dynamic import/reload of the pygeoapi Starlette app and applies formatting tweaks to long strings/comments.
tests/test_pygeoapi_mount.py Adds unit tests validating the import-vs-reload behavior of _load_pygeoapi_app().

Copilot AI review requested due to automatic review settings March 25, 2026 21:34
@jirhiker jirhiker review requested due to automatic review settings March 25, 2026 21:34
@jirhiker jirhiker merged commit 4750f9d into staging Mar 25, 2026
3 checks passed
@jirhiker jirhiker deleted the fix-ogc-mounting branch March 25, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants