feat: implement dynamic loading of pygeoapi app and improve description formatting#617
Merged
feat: implement dynamic loading of pygeoapi app and improve description formatting#617
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pygeoapi mounting integration to dynamically (re)load the pygeoapi.starlette_app module at mount time, and cleans up a handful of long strings/comments for improved formatting consistency.
Changes:
- Added
_load_pygeoapi_app()to import or reloadpygeoapi.starlette_appand return itsAPPfor mounting. - Updated
mount_pygeoapi()to use the dynamic loader instead of a direct import. - Reformatted several long
descriptionstrings and a few long comments/error messages for readability.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
core/pygeoapi.py |
Introduces dynamic import/reload of the pygeoapi Starlette app and applies formatting tweaks to long strings/comments. |
tests/test_pygeoapi_mount.py |
Adds unit tests validating the import-vs-reload behavior of _load_pygeoapi_app(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?