Vue3/migrate plugin export#679
Open
jedi-of-the-sea wants to merge 32 commits intonextfrom
Open
Conversation
jedi-of-the-sea
force-pushed
the
vue3/migrate-plugin-export
branch
from
a952f9c to
6a5a4c5
Compare
dopenguin
added
enhancement
warm-coolguy
force-pushed
the
vue3/migrate-plugin-export
branch
from
c6ee5fe to
2e4ac86
Compare
|
warm-coolguy
force-pushed
the
vue3/migrate-plugin-export
branch
from
2e4ac86 to
da29f62
Compare
warm-coolguy
requested review from
dopenguin,
oeninghe-dataport and
warm-coolguy
as code owners
dopenguin
requested changes
May 6, 2026
Member
dopenguin
left a comment
dopenguin
left a comment
There was a problem hiding this comment.
Works in Safari ✅
🏓 @warm-coolguy
Comment on lines
+6
to
+8
| * Supported export formats. 'jpg' and 'jpeg' are effectively the same format, | ||
| * so you can provide whatever you prefer. Providing both is not recommended | ||
| * due to the confusing nature of having both options. |
Member
There was a problem hiding this comment.
I'd prefer including the part regarding jpg and jpeg under @remarks of formats
Member
There was a problem hiding this comment.
See https://github.com/Dataport/polar/pull/679/changes#r3203001072 where I meant it to be placed.
Member
|
apply suggestion "fix typo" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
apply suggestion "add tics" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
warm-coolguy
force-pushed
the
vue3/migrate-plugin-export
branch
from
12a26ec to
989d696
Compare
dopenguin
reviewed
May 7, 2026
Member
|
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The export plugin has been migrated to POLAR@3.
Instructions for local reproduction and review
In this effort, the required monkey patch has been tied to the export plugin itself, and can be turned on and off. However, since there is currently no mechanism to re-create the canvas, it remains tainted, and holds the same caveats as in POLAR@2.
The plugin itself may be tested in the iceberg client, run
npm run devand open http://localhost:1234/examples/iceberg/#.You may also test changing the configuration, e.g. to a single export, or to not have an automated download.
Pull Request Checklist (for Assignee)
Changelogs are maintainedCurrently no changelogs featuredSafari@dopenguin pls check SafariUI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)