Use package plotly.js-dist#52
Open
tkallage wants to merge 2 commits into
Open
Conversation
|
If this can be merged, it would be really great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses plotly.js-dist as the plotly dependency.
In combination with #49 this enables the use of this package in vite (vue 2.7), fixing #47.
The difference between this PR and #46 is that this PR does not contain any style/formatting changes and the tests are also considered.
The circleci test-pipeline is currently failing, but the underlying issue should be resolved with #50.