Skip to content

fix(transactions): (WIP) use vsize when calculating feeRate#1641

Draft
kyleleow wants to merge 1 commit intomainfrom
kengye/use-vsize-feerate
Draft

fix(transactions): (WIP) use vsize when calculating feeRate#1641
kyleleow wants to merge 1 commit intomainfrom
kengye/use-vsize-feerate

Conversation

@kyleleow
Copy link
Copy Markdown
Contributor

@kyleleow kyleleow commented Jan 9, 2023

What this PR does / why we need it:

  • To display vSize in summary table
  • To use vSize when calculating feeRate

Which issue(s) does this PR fixes?:

Fixes #

Sample Links & Screenshots:

Link:

Desktop Screenshot
Mobile Screenshot

Additional comments?:

  • TODO: Cannot replace size with vSize directly, need to have condition check if tx is using segwit address or not

Developer Checklist:

  • Read your code changes at least once
  • Tested on multiple web browsers
  • Tested responsiveness (e.g, iPhone, iPad, Desktop)
  • No console errors
  • Unit tests*
  • Added e2e tests*

Display vSize in summary table
@kyleleow kyleleow self-assigned this Jan 9, 2023
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 9, 2023

Deploy Preview for defi-scan ready!

Name Link
🔨 Latest commit 2a63846
🔍 Latest deploy log https://app.netlify.com/sites/defi-scan/deploys/63bc36bc795b7900082daad3
😎 Deploy Preview https://deploy-preview-1641--defi-scan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyleleow kyleleow changed the title fix(transactions): use vsize when calculating feeRate fix(transactions): (WIP) use vsize when calculating feeRate Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant