Draft
Conversation
jordankzf
requested review from
G9000,
JoshuaC817,
chloezxyy,
fullstackninja864,
joeldavidw,
kyleleow,
nichellekoh,
pierregee and
thedoublejay
as code owners
✅ Deploy Preview for defi-scan ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jordankzf
force-pushed
the
jordankzf/remove-percentage-neutral-votes
branch
from
ae1286b to
68fa0cb
Compare
jordankzf
changed the title
jordankzf
changed the title
github-actions
bot
added
kind/fix
thedoublejay
approved these changes
Mar 8, 2023
Contributor
|
@jordankzf will reenable post HF |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Neutral votes percentage is no longer shown, however they are still taken into account when calculating yes and no vote percentages. The progress bar output does not tally to 100% due to this.
Which issue(s) does this PR fixes?:
Fixes WEB-311
Sample Links & Screenshots:
Link:
Desktop Screenshot
Mobile Screenshot
Additional comments?:
Developer Checklist: