Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
__init__.pyfiles for rig modules was overly complex. While it was nice that it made it so that you never have to update when you create new modules, it's needlessly complicated and it's preferred to just manually declare them.This could also give us the benefit of having an easy way to have "unpublished" modules, if they're just not included in their respective
__init__.pyfile.I also updated the test runner to always do the stdout fix, since I was still getting an error.
(Overall, this is mostly just fixing old, bad code that I wrote a while back)
Also did some formatting updates