fix: make prompt required for lucy-2-v2v (can be empty string)#99
Merged
AdirAmsalem merged 1 commit intomainfrom Mar 9, 2026
Merged
fix: make prompt required for lucy-2-v2v (can be empty string)#99AdirAmsalem merged 1 commit intomainfrom
AdirAmsalem merged 1 commit intomainfrom
Conversation
Update lucy-2-v2v model schema to match API spec change where prompt is now a required field that accepts empty strings. Remove the 'at least one of prompt or reference_image' validation since prompt is always required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompta required field forlucy-2-v2vmodel (can be empty string"").min(1)validation to allow empty strings.refine()validation requiring "at least one of prompt or reference_image"VideoEdit2Inputsinterface:promptis now non-optionalContext
The API spec (
openapi.json) changedpromptfrom optional to"required": ["data", "prompt"]with description: "Text prompt. Send an empty string if you want no text prompt."Changes
src/shared/model.tssrc/process/types.tsprompt: string(non-optional)tests/unit.test.tstests/e2e.test.tsprompt: ""to ref-image testexamples/sdk-core/video/video-editing.tsprompt: ""to Option 2Note
Medium Risk
Medium risk because it changes the public SDK contract and runtime validation for
lucy-2-v2v, potentially breaking callers that previously omittedpromptwhen using onlyreference_image. The change is straightforward and covered by updated unit/e2e tests and examples.Overview
Aligns
lucy-2-v2vinputs with the updated API spec by makingpromptrequired while allowing it to be an empty string.Updates the TypeScript inputs (
VideoEdit2Inputs) and Zod validation schema to drop the “at least one ofprompt/reference_image” rule, and adjusts tests and examples to passprompt: ""for reference-image-only edits.Written by Cursor Bugbot for commit f831e12. This will update automatically on new commits. Configure here.