internal/ui: prevent spurious profile switch when opening main window#281
Closed
gitzone83 wants to merge 1 commit intoDeedleFake:masterfrom
Closed
internal/ui: prevent spurious profile switch when opening main window#281gitzone83 wants to merge 1 commit intoDeedleFake:masterfrom
gitzone83 wants to merge 1 commit intoDeedleFake:masterfrom
Conversation
When the main window opens or receives a ProfileStatus update, updateProfiles() rebuilds the dropdown model, which resets the selection to index 0. This fires the selected-item notification handler, which calls SwitchProfile for the wrong profile — silently switching tailnets without user action. Two guards added: - updatingProfiles flag: set during updateProfiles(), causes the notification handler to skip SwitchProfile calls triggered by programmatic model rebuilds - activeProfileID check: compares the selected profile against the currently active profile and skips the switch if they match, preventing redundant SwitchProfile calls even outside of model rebuilds Fixes DeedleFake#277
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateProfiles()rebuilds the dropdown model, resetting the selection to index 0. This fires theselected-itemnotification handler, which callsSwitchProfilefor the wrong profile — silently switching tailnets without user action.updatingProfilesflag to skipSwitchProfilecalls triggered by programmatic model rebuildsactiveProfileIDcheck to skip redundant switches even outside of model rebuildsFixes #251