Modernize code base and enable saving to external storage#12
Open
jaredning wants to merge 15 commits into
Open
Modernize code base and enable saving to external storage#12jaredning wants to merge 15 commits into
jaredning wants to merge 15 commits into
Conversation
…es, and fix TabLayout indicator being inaccurate
…oad button so that chapters can be downloaded without opening them. remove unnecessary logs, fix overly aggressive GC, fix potential memory leaks, and improve performance when reading a chapter that's currently downloading
…smoothness when loading data off an SD card, compared to the original app when loading chapters from internal storage
… signed apk to crash and fix delete chapter button not working
…ion when downloading multiple chapters at once causing chapters to fall out of sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, I forked the repo, modernized the code and made some of the changes I've been wanting to see for a while and it works great for my purposes. I doubt anyone else is still using this (although I'll note I have yet to find a better alternative that works on my Android 7.1.1 tablet) but just in case - here's the PR:
And yes, this was 100% done with Gemini - The file system changes I probably could've figured out on my own, but I have zero Android experience so tackling a migration of this size would've been impossible otherwise.
The original functionality should've all been more-or-less maintained, as far as I can tell - although I worry some of the changes around keeping the delete chapter functionality working are probably pretty close to AI slop, but my goal was just to make the improvements I needed without breaking the rest of the app.
Also, this breaks compatibility with Android versions pre 6.0 - seems worth noting considering the original app in its current form supports Android 4.1.
I created my own APK from my fork here for download if anyone's interested.
EDIT: I'm still fixing bugs as I find them, but this is close to being at the very least stable, with functionality akin to the original app. There are some QOL improvements I can think of that would be worth doing, especially to streamline things for users other than me, such as:
I'll see how I feel about these based on my testing / personal use - but for now, the goal now is to ensure the app is stable, and most importantly that the original functionality is also preserved on top of the changes I've added.