[feature] SC-166737/improve app proxy security by restricting where token replacements can go#78
Open
HappyPaul55 wants to merge 1 commit intomainfrom
Conversation
…oken replacements can go
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security for the Azure DevOps app by restricting the proxy whitelist from accepting any HTTPS URL to only specific Azure DevOps endpoints. It introduces settings injection capabilities that allow secure token and secret placement in request headers and bodies.
Key changes:
- Replaced wildcard HTTPS proxy whitelist with four specific Azure DevOps endpoint patterns
- Added
settingsInjectionconfiguration for secure credential injection into headers and request bodies - Enabled OAuth2 token refresh flow support through the Visual Studio OAuth2 endpoint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 30ff38e deployed to: https://azure-devops-pr-78.ci.next.deskprodemo.com URLs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the proxy configuration in
manifest.jsonto improve security and support for Azure DevOps endpoints. The changes restrict allowed proxy URLs, add new endpoint support, and introduce settings injection for authorization and secrets.Proxy configuration updates:
https://dev.azure.com/.*,https://vssps.dev.azure.com/.*,https://app.vssps.visualstudio.com/oauth2/.*, andhttps://__instance_url__/.*) to enhance security.settingsInjectionfor each endpoint, allowing secure injection of authorization tokens and secrets into request headers or bodies.