Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR bumps a set of runtime and dev dependencies to newer minor/patch versions in package.json and syncs pnpm-lock.yaml accordingly, with no code changes beyond the lockfile update. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The upgrade to
jest-environment-jsdom@30.xwhile keepingjest@29.xmay introduce version mismatch issues, since v30 is designed for Jest 30; consider keeping these on the same major version or confirming compatibility explicitly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The upgrade to `jest-environment-jsdom@30.x` while keeping `jest@29.x` may introduce version mismatch issues, since v30 is designed for Jest 30; consider keeping these on the same major version or confirming compatibility explicitly.
## Individual Comments
### Comment 1
<location> `package.json:64` </location>
<code_context>
"eslint-plugin-react-hooks": "4.3.0",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "^2.8.8",
"rollup-plugin-copy": "3.4.0",
</code_context>
<issue_to_address>
**issue (testing):** Align jest-environment-jsdom major version with Jest to avoid subtle test runtime issues.
Jest is still on ^29.7.0 while jest-environment-jsdom is on ^30.2.0. Since jest-environment-jsdom majors usually track Jest majors, this mismatch can cause subtle or breaking test behavior. Please either keep jest-environment-jsdom on a 29.x release or upgrade Jest to 30.x so their major versions stay aligned.
</issue_to_address>
### Comment 2
<location> `package.json:69` </location>
<code_context>
- "typescript": "^5.8.3",
- "vite": "^6.3.6"
+ "ts-jest": "^29.4.6",
+ "typescript": "^5.9.3",
+ "vite": "^6.4.1"
}
</code_context>
<issue_to_address>
**suggestion (testing):** Double‑check ts-jest compatibility with TypeScript 5.9.x.
Since TypeScript is upgraded to ^5.9.3 while ts-jest stays at ^29.4.6, please verify that this ts-jest version officially supports TS 5.9, or bump ts-jest to a release that does. Version skew here can cause hard-to-diagnose test compile/type errors.
Suggested implementation:
```
"slugify": "^1.6.6",
"ts-jest": "^29.5.0",
"typescript": "^5.9.3",
"vite": "^6.4.1"
```
1. After bumping `ts-jest`, run `npm install` or `yarn install` to update the lockfile.
2. Run the Jest test suite to confirm there are no new compilation or type errors introduced by the new `ts-jest`/TypeScript combination.
3. If your actual supported version (per `ts-jest`'s official compatibility table) is different from `^29.5.0`, adjust the version in `package.json` accordingly.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| "eslint-plugin-react-hooks": "4.3.0", | ||
| "jest": "^29.7.0", | ||
| "jest-environment-jsdom": "^30.0.5", | ||
| "jest-environment-jsdom": "^30.2.0", |
There was a problem hiding this comment.
issue (testing): Align jest-environment-jsdom major version with Jest to avoid subtle test runtime issues.
Jest is still on ^29.7.0 while jest-environment-jsdom is on ^30.2.0. Since jest-environment-jsdom majors usually track Jest majors, this mismatch can cause subtle or breaking test behavior. Please either keep jest-environment-jsdom on a 29.x release or upgrade Jest to 30.x so their major versions stay aligned.
| "typescript": "^5.8.3", | ||
| "vite": "^6.3.6" | ||
| "ts-jest": "^29.4.6", | ||
| "typescript": "^5.9.3", |
There was a problem hiding this comment.
suggestion (testing): Double‑check ts-jest compatibility with TypeScript 5.9.x.
Since TypeScript is upgraded to ^5.9.3 while ts-jest stays at ^29.4.6, please verify that this ts-jest version officially supports TS 5.9, or bump ts-jest to a release that does. Version skew here can cause hard-to-diagnose test compile/type errors.
Suggested implementation:
"slugify": "^1.6.6",
"ts-jest": "^29.5.0",
"typescript": "^5.9.3",
"vite": "^6.4.1"
- After bumping
ts-jest, runnpm installoryarn installto update the lockfile. - Run the Jest test suite to confirm there are no new compilation or type errors introduced by the new
ts-jest/TypeScript combination. - If your actual supported version (per
ts-jest's official compatibility table) is different from^29.5.0, adjust the version inpackage.jsonaccordingly.
|
Build for commit 6f48efe deployed to: https://github-pr-91.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Pull request overview
This pull request upgrades multiple dependencies to their latest minor and patch versions, including both production and development dependencies. The updates aim to incorporate bug fixes, performance improvements, and new features from newer package versions.
Key Changes:
- Updated 11 production dependencies including core libraries like
@deskpro/app-sdk,@fortawesome/react-fontawesome,@sentry/react,formik, andreact-router-dom - Updated 6 development dependencies including
@types/lodash,@types/react,jest-environment-jsdom,ts-jest,typescript, andvite - All pnpm-lock.yaml changes are automatically generated and consistent with package.json updates
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates version specifiers for 17 dependencies with mostly minor/patch version bumps |
| pnpm-lock.yaml | Automatically generated lockfile reflecting the dependency tree changes from package.json updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@deskpro/deskpro-ui": "^8.4.0", | ||
| "@fortawesome/free-solid-svg-icons": "^6.7.2", | ||
| "@fortawesome/react-fontawesome": "^0.2.2", | ||
| "@fortawesome/react-fontawesome": "^0.2.6", |
There was a problem hiding this comment.
The package "@fortawesome/react-fontawesome" at version "^0.2.6" is deprecated. The deprecation notice indicates that v0.2.x is no longer supported unless using FontAwesome 5, and recommends updating to v3.1.1 or greater. Consider upgrading to the latest v3.x version for continued support and compatibility.
| "@fortawesome/react-fontawesome": "^0.2.6", | |
| "@fortawesome/react-fontawesome": "^3.1.1", |
1 participant
This pull request updates several dependencies in the
package.jsonfile to their latest minor or patch versions. These updates include both production and development dependencies, aiming to keep the project up-to-date with bug fixes, performance improvements, and new features.Dependency updates:
@deskpro/app-sdk,@deskpro/deskpro-ui,@fortawesome/react-fontawesome,@sentry/react,@sentry/vite-plugin,formik,javascript-time-ago,react-router-dom,react-time-ago,simplebar, andstyled-componentsto newer versions.@types/lodash,@types/react,jest-environment-jsdom,ts-jest,typescript, andviteto their latest versions. [1] [2]Summary by Sourcery
Update project dependencies to newer minor and patch versions across runtime and development tooling.
Build: