Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR bumps several runtime and dev-time dependencies in package.json (Deskpro SDK/UI, Sentry, React types, Jest JSDOM environment, styled-components, TypeScript, Vite) and refreshes pnpm-lock.yaml to match, without changing application logic. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Upgrading
jest-environment-jsdomto^30.2.0while keepingjestat^29.7.0introduces a major-version mismatch; consider aligning their major versions or confirming that this combo is explicitly supported. - Bumping
typescriptto^5.9.3withts-jeststill at^27.1.5may exceed the TypeScript version range thatts-jestofficially supports; it’s worth verifying compatibility or updatingts-jestaccordingly to avoid subtle build/test issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Upgrading `jest-environment-jsdom` to `^30.2.0` while keeping `jest` at `^29.7.0` introduces a major-version mismatch; consider aligning their major versions or confirming that this combo is explicitly supported.
- Bumping `typescript` to `^5.9.3` with `ts-jest` still at `^27.1.5` may exceed the TypeScript version range that `ts-jest` officially supports; it’s worth verifying compatibility or updating `ts-jest` accordingly to avoid subtle build/test issues.
## Individual Comments
### Comment 1
<location> `package.json:54-55` </location>
<code_context>
"slugify": "^1.6.6",
- "styled-components": "^6.1.19",
+ "styled-components": "^6.2.0",
"ts-jest": "^27.1.5",
- "typescript": "^5.8.3",
- "vite": "^6.3.6"
+ "typescript": "^5.9.3",
+ "vite": "^6.4.1"
}
</code_context>
<issue_to_address>
**issue (testing):** Validate `ts-jest@27` compatibility with Jest 29 and TypeScript 5.9.
`ts-jest@27.1.5` targets the Jest 27 timeframe and may not officially support Jest 29 or TypeScript 5.9.3, which can cause transformer/config or type-checking issues. Please verify the supported Jest/TypeScript ranges for this version and consider upgrading `ts-jest` (and aligning Jest) to a version that explicitly supports TS 5.9 and your Jest version.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This pull request upgrades multiple dependencies and development dependencies to their latest versions, including core packages like @deskpro/app-sdk, @deskpro/deskpro-ui, Sentry packages, testing libraries, and build tools. The updates include both minor and patch version increments aimed at incorporating bug fixes, security patches, and new features.
Key Changes:
- Core dependency upgrades:
@deskpro/app-sdk(6.0.6 → 6.0.8),@deskpro/deskpro-ui(8.3.1 → 8.4.0), Sentry packages (~9.38.0 → ~9.47.1) - Development dependency upgrades: TypeScript (5.8.3 → 5.9.3), Vite (6.3.6 → 6.4.1), Jest environment, styled-components, and type definitions
- Lock file synchronization with updated transitive dependencies
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates dependency and devDependency version specifiers for 10 packages |
| pnpm-lock.yaml | Synchronizes lock file with new dependency versions and resolves transitive dependency updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 591b868 deployed to: https://scratchpad-pr-70.ci.next.deskprodemo.com URLs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several dependencies and development dependencies in the
package.jsonfile to newer versions. These upgrades help keep the project up-to-date with the latest features, bug fixes, and security patches.Dependency updates:
@deskpro/app-sdkto 6.0.8,@deskpro/deskpro-uito 8.4.0,@sentry/reactto 9.47.1, and@sentry/vite-pluginto 3.6.1.@types/reactto 17.0.90,jest-environment-jsdomto 30.2.0,styled-componentsto 6.2.0,typescriptto 5.9.3, andviteto 6.4.1. [1] [2]Summary by Sourcery
Update project dependencies to the latest compatible versions.
Build: