[feature] SC-166737/improve app proxy security by restricting where token replacements can go#91
Open
HappyPaul55 wants to merge 2 commits intomainfrom
Conversation
…oken replacements can go
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSecure injection of Zoom OAuth credentials into request headers via manifest configuration and removal of unused placeholder constants to streamline the codebase. Class diagram for removed placeholder constants in constants.tsclassDiagram
class Constants {
+ACCESS_TOKEN
+REFRESH_TOKEN_PATH
+REFRESH_TOKEN
+REST_URL
}
%% Removed: placeholders { client_id, client_secret }
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Build for commit 8704730 deployed to: https://zoom-pr-91.ci.next.deskprodemo.com URLs: |
…oken replacements can go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to how sensitive Zoom OAuth credentials are handled and simplifies the codebase by removing unused constants. The main focus is on securely injecting
client_idandclient_secretinto request headers for OAuth calls, and cleaning up unused placeholder variables.Zoom OAuth credential handling:
manifest.jsonto injectclient_idandclient_secretinto theAuthorizationheaders for POST requests, improving security and flexibility.Codebase cleanup:
placeholdersforclient_idandclient_secretfromsrc/constants.ts, reducing clutter and potential confusion.Summary by Sourcery
Securely inject Zoom OAuth credentials into request headers for POST calls and clean up unused placeholder constants
New Features:
Chores: