fix: resolve syntax error in public routes#266
Open
aditya-narayan007 wants to merge 2 commits into
Open
Conversation
Harxhit
added
the
gssoc:approved
Collaborator
|
Please fix the merge conflicts. |
Collaborator
|
Fix the merge conflicts please and pin me. |
Author
|
Fixed the merge conflicts. @Harxhit Please review. |
Harxhit
reviewed
May 24, 2026
Collaborator
There was a problem hiding this comment.
Can you please explain what changes did made in this file? All I see removed spacing.
Author
There was a problem hiding this comment.
The main fix was actually the incorrect nested app.get() route definitions inside public.ts, which was causing the syntax/TypeScript issue.
I removed the duplicated nested routes for /:username and /:username/card/:cardId and restored the proper Fastify route structure.
The spacing/indentation changes are just a side effect of restructuring the block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #265
This PR fixes the backend startup failure caused by syntax/parsing errors in
apps/backend/src/routes/public.ts.Changes Made
Removed duplicated nested
app.get()route definitionsFixed route handler structure for:
/:username/:username/card/:cardIdRestored proper Fastify route syntax and balanced closing brackets/parentheses
Verification
Verified backend TypeScript compilation using:
pnpm --filter @devcard/backend exec tsc --noEmitConfirmed the backend no longer crashes due to:
Issue
Fixes the backend startup parsing error in
public.ts.