test(shared): add unit tests for getProfileUrl, getWebViewUrl, getDee…#296
Open
amritbej wants to merge 1 commit into
Open
test(shared): add unit tests for getProfileUrl, getWebViewUrl, getDee…#296amritbej wants to merge 1 commit into
amritbej wants to merge 1 commit into
Conversation
…pLinkUrl Closes Dev-Card#10 - tests getProfileUrl('github', 'octocat') → https://github.com/octocat - tests getWebViewUrl('linkedin', 'john') → correct LinkedIn webview URL - tests getDeepLinkUrl('twitter', 'john') → correct Twitter deep link URL - covers null returns for unsupported and unknown platforms - follows existing Vitest describe/it/expect style
Harxhit
added
the
gssoc:approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit test coverage for shared URL utility functions in
packages/shared/src/platforms.ts.Closes #10
Type of Change
What Changed
Added
packages/shared/src/__tests__/platforms-url.test.tsAdded tests for:
getProfileUrl('github', 'octocat')getWebViewUrl('linkedin', 'john')getDeepLinkUrl('twitter', 'john')Added coverage for unsupported/unknown platforms returning
nullFollowed existing Vitest testing conventions used in the repository
How to Test
pnpm --filter shared testChecklist
pnpm -r run lintpasses).pnpm -r run typecheck).pnpm -r run test).console.logor debug statements left in the code.Additional Context
This PR focuses only on improving test coverage for shared URL utility helpers without modifying existing application behavior.