fix(analytic): resolve analytics lint issues, add route generics, and add tests#317
Open
Harxhit wants to merge 2 commits into
Open
fix(analytic): resolve analytics lint issues, add route generics, and add tests#317Harxhit wants to merge 2 commits into
Harxhit wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves analytics route reliability and maintainability by resolving lint issues, introducing stronger Fastify route typing using route generics, and adding automated test coverage for analytics endpoints. These changes improve TypeScript safety and ensure analytics functionality is validated through tests.
Type of Change
What Changed
analytics.ts, including unused variables and ESLintunbound-methodwarnings for authentication handlers./viewsto improve query typing and TypeScript safety./overviewand/views) using mocked Prisma and Fastify inject-based testing.How to Test
pnpm test analytics.test.ts