Skip to content

fix: add noreferrer to external GitHub link#324

Open
charu2210 wants to merge 1 commit into
Dev-Card:mainfrom
charu2210:fix-external-links
Open

fix: add noreferrer to external GitHub link#324
charu2210 wants to merge 1 commit into
Dev-Card:mainfrom
charu2210:fix-external-links

Conversation

@charu2210
Copy link
Copy Markdown

Summary

Adds the missing noreferrer value to an external GitHub link opened with target="_blank" in the landing page.

Closes #262


Type of Change

  • Bug fix
  • New feature
  • Refactor (no functional change)
  • UI / Design change
  • Tests only
  • Documentation
  • Infrastructure / DevOps
  • Security

What Changed

  • Updated the external GitHub link in apps/web/src/routes/+page.svelte
  • Added rel="noreferrer" alongside noopener
  • Improved external link security best practices for links opened in new tabs

How to Test

  1. Run the application locally using pnpm dev
  2. Open the landing page
  3. Click the GitHub button and verify it opens securely in a new tab

Checklist

  • My code follows the project's coding style (pnpm -r run lint passes).
  • TypeScript compiles without errors (pnpm -r run typecheck).
  • I have added or updated tests for the changes I made.
  • All tests pass locally (pnpm -r run test).
  • I have updated documentation where necessary.
  • No new console.log or debug statements left in the code.
  • Breaking changes are documented in this PR description.

Additional Context

This PR addresses a remaining external link that used target="_blank" without the complete recommended rel="noopener noreferrer" configuration.

@Harxhit Harxhit added the gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking. label May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security + UX: Open external profile links in new tab

2 participants