Skip to content

fix(cards): improve typing, transaction safety, and resolve lint issues #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harxhit wants to merge 3 commits into
base: main
Choose a base branch
from
+46 −13
Open

fix(cards): improve typing, transaction safety, and resolve lint issues #327

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9171f0
fix: Fixed linting issues
Harxhit May 24, 2026
9e54f51
Merge remote-tracking branch 'upstream/main'
Harxhit May 24, 2026
f178f78
fix(cards): resolve lint issues and improve type safety
Harxhit May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 46 additions & 13 deletions apps/backend/src/routes/cards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
import type { Card } from '@devcard/shared';
import { createCardSchema, updateCardSchema } from '../utils/validators.js';
import { handleDbError } from '../utils/error.util.js';
import { createCardSchema, updateCardSchema } from '../utils/validators.js';

import type { Card } from '@devcard/shared';
import type { Prisma } from '@prisma/client';
import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';


interface CreateCardBody {
title: string;
Expand All @@ -17,8 +20,36 @@ interface CardParams {
id: string;
}

interface PlatformLink {
id: string;
userId: string;
platform: string;
username: string;
url: string;
displayOrder: number;
createdAt: Date;
}

interface CardLinkWithPlatform {
id: string;
cardId: string;
platformLinkId: string;
displayOrder: number;
platformLink: PlatformLink;
}

interface CardWithLinks {
id: string;
userId: string;
title: string;
isDefault: boolean;
createdAt: Date;
updatedAt: Date;
cardLinks: CardLinkWithPlatform[];
}

export async function cardRoutes(app: FastifyInstance): Promise<void> {
app.addHook('preHandler', app.authenticate);
app.addHook('preHandler', app.authenticate.bind(app));

// ─── List Cards ───

Expand All @@ -38,11 +69,11 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {
orderBy: { createdAt: 'asc' },
});

return cards.map((card) => ({
return cards.map((card:CardWithLinks) => ({
id: card.id,
title: card.title,
isDefault: card.isDefault,
links: card.cardLinks.map((cl) => cl.platformLink) as any,
links: card.cardLinks.map((cl) => cl.platformLink),
}));
} catch (error) {
return handleDbError(error, request, reply);
Expand Down Expand Up @@ -98,12 +129,14 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {
},
});

return reply.status(201).send({
id: card.id,
const response = {
id: card.id,
title: card.title,
isDefault: card.isDefault,
links: card.cardLinks.map((cl) => cl.platformLink) as any,
});
links: card.cardLinks.map((cl: CardLinkWithPlatform) => cl.platformLink),
}

return reply.status(201).send(response);
} catch (error) {
return handleDbError(error, request, reply);
}
Expand Down Expand Up @@ -153,7 +186,7 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {
// Replace links inside a transaction so the card is never left linkless
// when deleteMany succeeds but createMany subsequently fails.
const linkIds = parsed.data.linkIds;
await app.prisma.$transaction(async (tx) => {
await app.prisma.$transaction(async (tx:Prisma.TransactionClient) => {
await tx.cardLink.deleteMany({ where: { cardId: id } });
if (linkIds.length > 0) {
await tx.cardLink.createMany({
Expand Down Expand Up @@ -181,7 +214,7 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {
id: updated!.id,
title: updated!.title,
isDefault: updated!.isDefault,
links: updated!.cardLinks.map((cl) => cl.platformLink) as any,
links: updated!.cardLinks.map((cl:CardLinkWithPlatform) => cl.platformLink) as any,
};

return response;
Expand Down Expand Up @@ -253,7 +286,7 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {

// Clear then set in a single transaction so there is never a window where
// the user has zero default cards if the second write fails.
await app.prisma.$transaction(async (tx) => {
await app.prisma.$transaction(async (tx:Prisma.TransactionClient) => {
await tx.card.updateMany({ where: { userId }, data: { isDefault: false } });
await tx.card.update({ where: { id }, data: { isDefault: true } });
});
Expand Down