auth middleware for header authencation#5
Merged
Ifechukwu001 merged 4 commits intoApr 18, 2025
Conversation
Ifechukwu001
requested changes
Apr 15, 2025
Contributor
Ifechukwu001
left a comment
Ifechukwu001
left a comment
There was a problem hiding this comment.
So far, the flow looks okay. I believe it should work fine; just a few little changes here and there so it can pass Pyright.
As for the OpenAPI spec, I think there might be a cleaner way to do it. But if not, we can go with this.
Ifechukwu001
approved these changes
Apr 18, 2025
Contributor
Ifechukwu001
left a comment
Ifechukwu001
left a comment
There was a problem hiding this comment.
This is a good job. I'll merge it now
| "pydantic[email]>=2.10.6", | ||
| "django-ninja>=1.3.0", | ||
| "pyjwt>=2.10.1", | ||
| "typing>=3.10.0.0", |
Contributor
There was a problem hiding this comment.
Is typing not a builtin package?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2