user registration and email verification with queue#7
Merged
Ifechukwu001 merged 5 commits intoApr 29, 2025
Merged
Conversation
Contributor
Ifechukwu001
left a comment
There was a problem hiding this comment.
Same issues I talked about on security in the auth service, but overall. The Changes are good
| "pyjwt>=2.10.1", | ||
| "faststream[rabbit]>=0.5.39", | ||
| "starlette>=0.46.2", | ||
| "django-extensions>=4.1", |
Contributor
There was a problem hiding this comment.
What's the django extensions for?
And requests?
Contributor
Author
There was a problem hiding this comment.
I was testing something with requests. Will remove it
django extension is for listing the endpoints URL, more of a dev dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4