Skip to content

Add Franka FR3#123

Merged
yuecideng merged 1 commit intomainfrom
cj/add-franka-fr3
Feb 6, 2026
Merged

Add Franka FR3#123
yuecideng merged 1 commit intomainfrom
cj/add-franka-fr3

Conversation

@matafela
Copy link
Collaborator

@matafela matafela commented Feb 6, 2026

Description

Add Franka FR3

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

Checklist

  • I have run the black . command to format the code base.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Dependencies have been updated, if applicable.

Copilot AI review requested due to automatic review settings February 6, 2026 08:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for the Franka FR3 robot model to the EmbodiChain framework. The change updates the Franka robot dataset class to include both the existing Panda variants and the new FR3 model, organizing them into separate subdirectories following the pattern established by other multi-variant robot classes in the codebase.

Changes:

  • Reorganized Franka directory structure to separate Panda and FR3 models into subdirectories
  • Updated zip file reference from "Franka.zip" to "FrankaV2.zip" with new MD5 hash
  • Added FR3 robot model (fr3.urdf) to the directory structure documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PandaHand.urdf
PandaWithHand.urdf
FR3/
fr3.urdf
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory structure documentation now includes FR3 support, but there's no corresponding example showing how to access the FR3 URDF file. Consider adding an example line like:
>>> print(get_data_path("Franka/FR3/fr3.urdf"))
to demonstrate how to use the new FR3 model, consistent with how other robot models with multiple variants show examples for each variant (e.g., Rokae shows examples for both SR3 and SR5).

Copilot uses AI. Check for mistakes.
PandaHand.urdf
PandaWithHand.urdf
FR3/
fr3.urdf
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FR3 URDF filename uses lowercase 'fr3.urdf' while the Panda variants use PascalCase (e.g., 'Panda.urdf', 'PandaHand.urdf'). For consistency with the existing Franka Panda naming convention, consider using 'FR3.urdf' instead of 'fr3.urdf'.

Suggested change
fr3.urdf
FR3.urdf

Copilot uses AI. Check for mistakes.
@yuecideng yuecideng merged commit b1550af into main Feb 6, 2026
11 checks passed
@yuecideng yuecideng deleted the cj/add-franka-fr3 branch February 6, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants