Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the Franka FR3 robot model to the EmbodiChain framework. The change updates the Franka robot dataset class to include both the existing Panda variants and the new FR3 model, organizing them into separate subdirectories following the pattern established by other multi-variant robot classes in the codebase.
Changes:
- Reorganized Franka directory structure to separate Panda and FR3 models into subdirectories
- Updated zip file reference from "Franka.zip" to "FrankaV2.zip" with new MD5 hash
- Added FR3 robot model (fr3.urdf) to the directory structure documentation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PandaHand.urdf | ||
| PandaWithHand.urdf | ||
| FR3/ | ||
| fr3.urdf |
There was a problem hiding this comment.
The directory structure documentation now includes FR3 support, but there's no corresponding example showing how to access the FR3 URDF file. Consider adding an example line like:
>>> print(get_data_path("Franka/FR3/fr3.urdf"))
to demonstrate how to use the new FR3 model, consistent with how other robot models with multiple variants show examples for each variant (e.g., Rokae shows examples for both SR3 and SR5).
| PandaHand.urdf | ||
| PandaWithHand.urdf | ||
| FR3/ | ||
| fr3.urdf |
There was a problem hiding this comment.
The FR3 URDF filename uses lowercase 'fr3.urdf' while the Panda variants use PascalCase (e.g., 'Panda.urdf', 'PandaHand.urdf'). For consistency with the existing Franka Panda naming convention, consider using 'FR3.urdf' instead of 'fr3.urdf'.
| fr3.urdf | |
| FR3.urdf |
Description
Add Franka FR3
Type of change
Checklist
black .command to format the code base.