Apy sources#209
Open
OluRemiFour wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Done, Close: #209 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #35
Summary
I have successfully completed the implementation of the Net APY Decomposition Donut Chart. Below is a summary of the accomplishments:
HTML Additions: Added donut chart containers to both the leverage preview (Order Panel) and the active Position details grid within frontend/index.html.
CSS Styling: Added responsive layout and color styles inside frontend/src/style.css using theme variables and custom styling for negative drag (e.g. half-opaque red and yellow slices).
Decomposition Math & SVG Path Calculations: Added getApyDecomposition() and renderNetApyPieChart() helpers in frontend/src/main.ts that proportionally scale all APR/compounded APY slices and dynamically draw arc paths so the components algebraic sum equals the displayed headline Net APY exactly.
Consistency: Updated all Net APY dashboard displays to subtract the dynamic 0.01 * leverage transaction/slippage drag, ensuring complete visual unity across cards, previews, and overview tables.
Validation: Built the production client bundle (npm run build) and typechecked (npm run typecheck) successfully with no new errors!
Related Issue
Closes #35
Checks
Notes for Reviewers