Add plan to get eiger data#43
Closed
jacob720 wants to merge 11 commits into
Closed
Conversation
DominicOram
requested changes
May 18, 2026
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks! One change, otherwise looks good.
Comment on lines
+51
to
+52
| yield from bps.abs_set(eiger.od.fp.data_chunks_0, 1, wait=True) | ||
| LOGGER.info("Setting # of Frame Chunks") |
Contributor
There was a problem hiding this comment.
Should: Is this required? Does the IOC not just default to this?
Contributor
Author
There was a problem hiding this comment.
I just restarted the IOC and this stayed as 1, so will delete
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 49.16% 56.87% +7.71%
==========================================
Files 8 9 +1
Lines 179 211 +32
==========================================
+ Hits 88 120 +32
Misses 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
requested changes
May 18, 2026
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Also, it's a bit weird that the logs come after the thing we're doing. e.g. I feel like:
LOGGER.info("Kickoff Eiger")
yield from bps.kickoff(eiger, wait=True)Makes more sense
Contributor
Author
|
Closed as captured in #51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a plan to trigger the eiger.
Requires DiamondLightSource/dodal#2058