Skip to content

fix(ci): preserve subscriptions when updating supergraph-config#174

Open
VictoriaBeilsten-Edmands wants to merge 1 commit into
mainfrom
vbe/update-subscriptions-ci
Open

fix(ci): preserve subscriptions when updating supergraph-config#174
VictoriaBeilsten-Edmands wants to merge 1 commit into
mainfrom
vbe/update-subscriptions-ci

Conversation

@VictoriaBeilsten-Edmands
Copy link
Copy Markdown
Collaborator

Currently, CI rewrites the supergraph-config and will delete subscription config and only rewrite it if subscription-url is passed. This PR changes the logic to "update" rather than "delete & rewrite". If no subscription-url is provided, any existing subscription config is retained.

Copy link
Copy Markdown
Collaborator

@EmsArnold EmsArnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants