Make Video (and Movie and Episode) a dataclass#1349
Draft
getzze wants to merge 3 commits into
Draft
Conversation
make Video a dataclass use attrs on Subtitle correct encoding since attrs.converter coverage add cattrs tests remove hatch command use a typed ensure_list do not show private members import outside TYPE_CHECKING for docs to compile without errors make hearing_impaired and foreign_only kw_only=True fix docs use keyword to init Episode make subtitle_id read-only because it is part of the hash Subtitle.subtitle_id is read-only change type of Video.subtitles from set to list Make Subtitle a hashable frozen dataclass, with a mutable SubtitleContent instance as attribute Subtitles is not an attrs dataclass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of #1094