Skip to content

Add Hungarian provider Hosszupuska#809

Open
morpheus133 wants to merge 15 commits into
Diaoul:mainfrom
morpheus133:develop_hosszupuska
Open

Add Hungarian provider Hosszupuska#809
morpheus133 wants to merge 15 commits into
Diaoul:mainfrom
morpheus133:develop_hosszupuska

Conversation

@morpheus133

Copy link
Copy Markdown

No description provided.

@morpheus133

Copy link
Copy Markdown
Author

Hi!
I see that test are runnig for lxml and native parser also.
But it seems for me that in case of this provider the results are different for them.
Which one I need to use?

Comment thread subliminal/providers/hosszupuska.py Outdated
def terminate(self):
self.session.close()

def GetLanguage(self, text):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason to mix conventions and use CamelCase in two methods while all the others follow the expected snake_case convention

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for the comment.
I corrected them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants