Add Subs4Series provider#948
Conversation
ratoaq2
left a comment
ratoaq2
left a comment
There was a problem hiding this comment.
I did an initial review and it looks very good.
Thanks for the contribution.
There was a problem hiding this comment.
While reviewing I found one major issue at the end of the review:
When the subtitle is an archiver (rar) for example, it's possible that inside an archiver you have multiple subtitles for different releases. This is similar to legendastv provider.
Each Subtitle class should represent a single subtitle (.srt) with a proper release/release_group, so the subtitles can be scored properly. So, most of the code in the download methods should happen before when you're listing subtitles, so a single rar file could return a list of subtitles.
I know @Diaoul you're not into this, but just want to let you know this is another case like legendastv where we had to download all the files during the list_subtitles in order to properly score them.
# Conflicts: # tests/test_extensions.py
|
@ratoaq2 This provider may bundle multiple releases in one archive, but only if the timings are the same. However, the scoring will not be affected because all releases are included in the subtitle's version, so the release matcher will successfully match against all releases. I have also created a branch in my fork with all 5 providers merged. Should I open a single PR with all the providers, or leave them as-is? |
2 participants
No description provided.