Skip to content

My example pull request title#3

Open
smith-kyle wants to merge 3 commits intomainfrom
temp-demo-1
Open

My example pull request title#3
smith-kyle wants to merge 3 commits intomainfrom
temp-demo-1

Conversation

@smith-kyle
Copy link
Copy Markdown
Member

No description provided.

@gitnotebooks
Copy link
Copy Markdown

gitnotebooks bot commented Oct 25, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/GitNotebooks/demo/pull/3

@gitnotebooks-staging
Copy link
Copy Markdown

Found 1 changed notebook. Review the changes at https://app-staging.gitnotebooks.com/GitNotebooks/demo/pull/3

Comment thread sklearn-example-2.ipynb
Comment thread utils.py
Copy link
Copy Markdown

@paulmlv-upstart paulmlv-upstart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, a few questions.

Comment thread sklearn-example-2.ipynb
@@ -0,0 +1,314 @@
{
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 1 Line 1

# Introducing Scikit-Learn

Optional: Add API link.

Comment thread sklearn-example-2.ipynb
@@ -0,0 +1,314 @@
{
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 10 Line 4

plt.scatter(data_projected[:, 0], data_projected[:, 1], c=digits.target,
            edgecolor='none', alpha=0.5,
            cmap=plt.cm.get_cmap('spectral', 10))
plt.colorbar(label='digit label', ticks=range(10))

Why range(10)?

Comment thread sklearn-example-2.ipynb
@@ -0,0 +1,314 @@
{
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 3 Line 5

import seaborn as sns
from utils import summarize_dataframe

iris = sns.load_dataset('iris')

test

Comment thread sklearn-example-2.ipynb
@@ -0,0 +1,314 @@
{
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 5 Line 2

iris['PCA1'] = X_2D[:, 0]
iris['PCA2'] = X_2D[:, 1]

test

Comment thread sklearn-example-2.ipynb
@@ -0,0 +1,314 @@
{
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 7 Line 1

### Unsupervised learning: Dimensionality reduction

test

Comment thread sklearn-example-2.ipynb
@@ -0,0 +1,314 @@
{
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 8 Line 2

from sklearn.manifold import Isomap
iso = Isomap(n_components=2)

test

Comment thread sklearn-example-2.ipynb
@@ -0,0 +1,314 @@
{
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 8 From line 2 to 4

iso = Isomap(n_components=2)
iso.fit(digits.data)
data_projected = iso.transform(digits.data)

test

Comment thread sklearn-example-2.ipynb
@@ -0,0 +1,314 @@
{
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 3 Line 1

import seaborn as sns

test

Comment thread sklearn-example-2.ipynb
@@ -0,0 +1,314 @@
{
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on notebook sklearn-example-2.ipynb Cell 3 Line 2

import seaborn as sns
from utils import summarize_dataframe

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants