Fix CI: install libfontconfig1-dev system dependency#3
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
Fix CI: install libfontconfig1-dev system dependency#3devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
The check, test, and clippy CI jobs were failing because the yeslogic-fontconfig-sys crate requires the fontconfig system library which was not installed on the CI runner. Inline the check, test, and clippy jobs (instead of using reusable workflows) so that libfontconfig1-dev can be installed before cargo commands run. The fmt job remains a reusable workflow call since it does not compile code. Co-Authored-By: Evan Almloff <evanalmloff@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All three compilation CI jobs (check, test, clippy) were failing with:
The
blitz-domdependency transitively requiresfontconfig(viayeslogic-fontconfig-sys), which needs thelibfontconfig1-devsystem package on Ubuntu.The reusable workflows from
dioxuslabs/dioxus-cidon't support installing system packages before cargo commands, so the check/test/clippy jobs are now inlined with anapt-get install -y libfontconfig1-devstep before thesetup-dioxusaction. Thefmtjob remains a reusable workflow call since it doesn't compile code.Link to Devin session: https://app.devin.ai/sessions/17011ec22d8c48b288a5421e6b895e01
Requested by: @ealmloff