feat(native): Add winit Event handler#5604
Closed
J0hannes101 wants to merge 4 commits into
Closed
Conversation
ealmloff
added
enhancement
J0hannes101
force-pushed
the
winit_event_handler
branch
from
9b57587 to
c137a51
Compare
nicoburns
requested changes
Jul 2, 2026
nicoburns
left a comment
nicoburns
left a comment
Member
There was a problem hiding this comment.
This seems like a good feature, but it shouldn't use a thead-local variable. It should probably use an Rc<RefCell<_>> type shared between the Window and the Dioxus context like Dioxus Desktop does (see the DesktopContext / DesktopService types)
nicoburns
added a commit
to nicoburns/blitz
that referenced
this pull request
Jul 7, 2026
This is a port of DioxusLabs/dioxus#5604 to the Blitz repo. Signed-off-by: Nico Burns <nico@nicoburns.com> Co-authored-by: Johannes Haase <johannes.haase@schneeberg-erz.de>
nicoburns
added a commit
to DioxusLabs/blitz
that referenced
this pull request
Jul 7, 2026
* Add global Winit WindowEvent handler This is a port of DioxusLabs/dioxus#5604 to the Blitz repo. Signed-off-by: Nico Burns <nico@nicoburns.com> Co-authored-by: Johannes Haase <johannes.haase@schneeberg-erz.de> * Add ctrl+t and ctrl+w shortcuts to browser app --------- Signed-off-by: Nico Burns <nico@nicoburns.com> Co-authored-by: Johannes Haase <johannes.haase@schneeberg-erz.de>
Member
|
I've ported this to the upstream version of Dioxus Native in the Blitz repo: DioxusLabs/blitz#493 (I've credited you as Co-Author :)) This repo should get the change next time it syncs from upstream :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
use_winit_event_handler()hook to the native renderer, allowing to register callbacks that fire on winitWindowEvent- analogous touse_wry_event_handler()on desktop.