fix: make IndexHtml public to bring back with_index_html()#5669
Open
xenzh wants to merge 1 commit into
Open
Conversation
Dioxus 0.6.x allowed to inject a custom index.html string via `ServeConfigBuilder::new().index_html(s)`; 0.7.x replaced it with `ServeConfig::with_index_html()` that takes `IndexHtml`, but this type was left `pub(crate)`. This change makes the type public along with three constructors (which are already `pub`). I've also replaced anyhow::Error with a dedicated type since now it's a part of public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
ServeConfigBuilder::new().index_html(s)ServeConfig::with_index_html()that takesIndexHtml, but this type was leftpub(crate).pub).anyhow::Errorwith a dedicated type since now it's a part of public API.I don't think this exposes anything unintended - but please let me know if I missed anything.
Testing
/publiccontents embedded into the server binary).