Skip to content

fix: make IndexHtml public to bring back with_index_html()#5669

Open
xenzh wants to merge 1 commit into
DioxusLabs:mainfrom
xenzh:expose-index-html
Open

fix: make IndexHtml public to bring back with_index_html()#5669
xenzh wants to merge 1 commit into
DioxusLabs:mainfrom
xenzh:expose-index-html

Conversation

@xenzh

@xenzh xenzh commented Jul 8, 2026

Copy link
Copy Markdown

Rationale

  • Dioxus 0.6.x allowed to inject a custom index.html string via ServeConfigBuilder::new().index_html(s)
  • 0.7.x replaced it (resolve the index before rendering #4806, follow up to serveconfig #4820) with ServeConfig::with_index_html() that takes IndexHtml, but this type was left pub(crate).
  • This change makes the type public along with three constructors (which are already pub).
  • I've also replaced anyhow::Error with a dedicated type since now it's a part of public API.

I don't think this exposes anything unintended - but please let me know if I missed anything.

Testing

Dioxus 0.6.x allowed to inject a custom index.html string via `ServeConfigBuilder::new().index_html(s)`;
0.7.x replaced it with `ServeConfig::with_index_html()` that takes `IndexHtml`, but this type was left `pub(crate)`.
This change makes the type public along with three constructors (which are already `pub`).
I've also replaced anyhow::Error with a dedicated type since now it's a part of public API.
@xenzh xenzh requested a review from a team as a code owner July 8, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant