Skip to content

Fix IDLE mode data control to use DATA_OFF_OUTSIDE instead of KEEP_DATA_IN_CAR#3

Closed
Doezer with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-sim-card-data-connection
Closed

Fix IDLE mode data control to use DATA_OFF_OUTSIDE instead of KEEP_DATA_IN_CAR#3
Doezer with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-sim-card-data-connection

Conversation

Copilot AI commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Mobile data not working with SIM card because apply_idle_profile() was checking the wrong config variable to control data connectivity.

Changes

  • Fixed variable usage in apply_idle_profile(): Changed from KEEP_DATA_IN_CAR to DATA_OFF_OUTSIDE
    • KEEP_DATA_IN_CAR controls data in WIRED/WIRELESS modes (in car)
    • DATA_OFF_OUTSIDE controls data in IDLE mode (outside car)

Before:

if [ "$KEEP_DATA_IN_CAR" = "1" ]; then 
  data_on
else 
  data_off
fi

After:

if [ "$DATA_OFF_OUTSIDE" = "1" ]; then
  data_off
else
  data_on
fi

Users wanting data always active should set DATA_OFF_OUTSIDE=0 in /sdcard/CarOS/config.env.

Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG] Data connection not working with SIM card in</issue_title>
<issue_description>I put a SIM card in, it is connectedin 4G but I don't have data</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

… KEEP_DATA_IN_CAR

Co-authored-by: Doezer <11655673+Doezer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix data connection issues with SIM card inserted Fix IDLE mode data control to use DATA_OFF_OUTSIDE instead of KEEP_DATA_IN_CAR Dec 1, 2025
Copilot AI requested a review from Doezer December 1, 2025 20:29
@Doezer Doezer marked this pull request as ready for review December 1, 2025 21:16
Copilot AI review requested due to automatic review settings December 1, 2025 21:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug in the IDLE profile where mobile data was not working correctly due to using the wrong configuration variable. The module manages device profiles based on Android Auto connection state (wired/wireless/idle), and each profile has specific configuration options for controlling mobile data.

Key Changes:

  • Fixed apply_idle_profile() to use DATA_OFF_OUTSIDE instead of KEEP_DATA_IN_CAR
  • Correctly inverted the conditional logic to match the variable's semantics

@Doezer Doezer closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Data connection not working with SIM card in

3 participants