Closed
Fix IDLE mode data control to use DATA_OFF_OUTSIDE instead of KEEP_DATA_IN_CAR#3
Conversation
… KEEP_DATA_IN_CAR Co-authored-by: Doezer <11655673+Doezer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix data connection issues with SIM card inserted
Fix IDLE mode data control to use DATA_OFF_OUTSIDE instead of KEEP_DATA_IN_CAR
Dec 1, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the IDLE profile where mobile data was not working correctly due to using the wrong configuration variable. The module manages device profiles based on Android Auto connection state (wired/wireless/idle), and each profile has specific configuration options for controlling mobile data.
Key Changes:
- Fixed
apply_idle_profile()to useDATA_OFF_OUTSIDEinstead ofKEEP_DATA_IN_CAR - Correctly inverted the conditional logic to match the variable's semantics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile data not working with SIM card because
apply_idle_profile()was checking the wrong config variable to control data connectivity.Changes
apply_idle_profile(): Changed fromKEEP_DATA_IN_CARtoDATA_OFF_OUTSIDEKEEP_DATA_IN_CARcontrols data in WIRED/WIRELESS modes (in car)DATA_OFF_OUTSIDEcontrols data in IDLE mode (outside car)Before:
After:
Users wanting data always active should set
DATA_OFF_OUTSIDE=0in/sdcard/CarOS/config.env.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.