fix: Imgproxy container exposure#740
Open
vladyslavprosolupov wants to merge 1 commit intoDokploy:canaryfrom
Open
fix: Imgproxy container exposure#740vladyslavprosolupov wants to merge 1 commit intoDokploy:canaryfrom
vladyslavprosolupov wants to merge 1 commit intoDokploy:canaryfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the imgproxy Dokploy template to explicitly declare the container’s internal listening port in Compose, addressing a deployment issue where imgproxy wasn’t reachable as expected on fresh Dokploy installs.
Changes:
- Add
expose: 8080to theimgproxyservice so its internal port is explicitly declared indocker-compose.yml.
|
Related Documentation 2 document(s) may need updating based on files changed in this PR: Dokploy's Space AGENTS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
@Siumauricio On fresh dokploy installation imgproxy container exposure was needed. Unfortunately, my previous implementation doesn't work as expected without direct expose in docker-compose.yml.
Checklist
Before submitting this PR, please make sure that:
Greptile Summary
This PR fixes container-to-container communication for the
imgproxyblueprint by adding an explicitexpose: - 8080directive to theimgproxyservice indocker-compose.yml. On fresh Dokploy installations, the platform relies on theexposedeclaration to wire up internal service routing, so without it nginx could not reach imgproxy on port 8080.expose: - 80pattern already present on thenginxservice.8080is imgproxy's default listen port and is already referenced in the nginxproxy_pass http://imgproxy:8080directive, so this is a consistent fix.expose(notports), which is the required convention for this repository per the Docker Compose guidelines.Confidence Score: 5/5
expose: - 8080directive that is already the established pattern for this repository (nginx already hasexpose: - 80), targets the correct default imgproxy port, does not introduceportsor any other prohibited directive, and directly resolves the reported deployment issue on fresh Dokploy installations.Last reviewed commit: 8d7fb61
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
Context used: