Open
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| - 8080 | ||
| command: ["-c", "/etc/nats/nats.conf"] | ||
| volumes: | ||
| - nats-data:/data |
There was a problem hiding this comment.
Volume mounted but JetStream not configured
The nats-data:/data volume is declared and mounted, but the nats.conf file (defined in template.toml) does not include a store_dir directive pointing to /data. Without store_dir: /data in the NATS config, JetStream persistence won't use this volume and it will remain empty.
If JetStream is not intended to be enabled, the volume can be removed. If persistence is desired, add store_dir: /data and jetstream {} to the config:
jetstream {
store_dir: /data
}
383ea56 to
0286ebf
Compare
Adds NATS 2.10.24 messaging server with token-based authentication and native WebSocket support (port 8080) for browser clients.
0286ebf to
44d8b2c
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is this PR about?
New PR of NATS — a high-performance, open-source messaging system for cloud-native applications, IoT, and microservices.
Checklist
Before submitting this PR, please make sure that:
Screenshots or Videos
Greptile Summary
This PR adds a new NATS messaging broker template (
blueprints/nats/) with a pinned Docker image (nats:2.10.24-alpine), a config file mount that enables token-based authentication and WebSocket support, monitoring and WebSocket domains, and registers the template inmeta.json. The template structure is sound and consistent with repository conventions.Key issues found:
meta.json— this is unrelated to the NATS PR and appears to be caused by a merge conflict or outdated base branch. Theblueprints/strapi/directory still exists, so Strapi would silently disappear from the template registry.nats-data:/datais mounted indocker-compose.ymlbut thenats.confdoes not include astore_dirdirective, so the volume will never be written to unless JetStream is manually configured post-deploy.nats.jpeg) is used instead of the preferred SVG format per contribution guidelines.Confidence Score: 2/5
Comments Outside Diff (2)
meta.json, line 5969-5984 (link)This PR removes the entire Strapi entry from
meta.json, but the PR description only mentions adding the NATS template. This appears to be an accidental deletion — possibly caused by a merge conflict or working off an outdated base branch.The
blueprints/strapi/directory still exists in the repository, so removing its metadata entry would make it disappear from the template registry without removing the underlying blueprint. Please restore the Strapi entry.blueprints/nats/nats.jpeg, line 1 (link)Per the project's contribution guidelines (AGENTS.md), logos should be SVG format at approximately 128×128px. A JPEG logo may appear blurry or pixelated at different display sizes. Consider replacing
nats.jpegwith an SVG version — the official NATS logo is available as an SVG from the NATS branding resources.Rule Used: AGENTS.md (source)
Last reviewed commit: "feat: add NATS templ..."
Context used: