Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| @@ -0,0 +1,39 @@ | |||
| version: "3.3" | |||
There was a problem hiding this comment.
Per the project's contribution guide, the Compose file version must be "3.8". Using "3.3" is a convention violation that may cause compatibility issues with Dokploy's compose handling.
| version: "3.3" | |
| version: "3.8" |
Context Used: AGENTS.md (source)
| master: | ||
| image: crawlabteam/crawlab:latest | ||
| container_name: crawlab_master |
There was a problem hiding this comment.
Service name must match blueprint folder name;
container_name must be removed
Two separate convention violations here:
- The service name must exactly match the blueprint folder name (
crawlab). Usingmasterbreaks the naming convention required by Dokploy — the domain config intemplate.tomlreferencesserviceName = "master", but the convention requires it to match the folder. container_namemust never be specified — Dokploy manages container naming. Explicit container names can cause conflicts across deployments.
| master: | |
| image: crawlabteam/crawlab:latest | |
| container_name: crawlab_master | |
| crawlab: | |
| image: crawlabteam/crawlab:latest |
Context Used: AGENTS.md (source)
| ports: | ||
| - "8080" | ||
| - "9666" |
There was a problem hiding this comment.
ports must not be used; use expose instead
Per the contribution guide, ports must never be included in Dokploy templates — Dokploy handles external port routing via its proxy layer. Use expose to declare internal ports without publishing them to the host.
| ports: | |
| - "8080" | |
| - "9666" | |
| expose: | |
| - "8080" | |
| - "9666" |
Context Used: AGENTS.md (source)
|
|
||
| services: | ||
| master: | ||
| image: crawlabteam/crawlab:latest |
There was a problem hiding this comment.
Unpinned image tag is a security risk
Using crawlabteam/crawlab:latest means any upstream change can silently alter the deployed version, including potentially breaking changes or supply chain attacks. The contribution guide explicitly requires images to be pinned to a specific version (e.g., crawlabteam/crawlab:0.6.0). The version field in meta.json must also match.
(Replace 0.6.0 with the actual latest stable release tag.)
Context Used: AGENTS.md (source)
|
|
||
| [config] | ||
| [[config.domains]] | ||
| serviceName = "master" |
There was a problem hiding this comment.
serviceName must match the corrected service name
Once the service in docker-compose.yml is renamed from master to crawlab (to comply with the folder-name convention), this value must be updated to match.
| serviceName = "master" | |
| serviceName = "crawlab" |
Context Used: AGENTS.md (source)
| [config.env] | ||
| MONGO_USERNAME = "${MONGO_USERNAME}" | ||
| MONGO_PASSWORD = "${MONGO_PASSWORD}" |
There was a problem hiding this comment.
Incorrect config format for environment variables
The contribution guide explicitly flags this as a common pitfall: environment variables in template.toml must be declared as an array of strings under [config], not as a TOML subtable ([config.env]). The current object-style subtable will not be parsed correctly by Dokploy. Please refer to the env array format described in AGENTS.md under the template.toml conventions section.
Context Used: AGENTS.md (source)
What is this PR about?
New PR of Crawlab (crawler management plateform)
Checklist
Before submitting this PR, please make sure that:
Issues related (if applicable)
Close automatically the related issues using the keywords:
closes #ISSUE_NUMBERScreenshots or Videos
Greptile Summary
This PR adds a Crawlab (distributed web crawler management platform) template to the blueprint collection, deploying a master node backed by MongoDB. While the core concept and
meta.jsonentry are solid, thedocker-compose.ymlandtemplate.tomlhave several violations of the mandatory Dokploy contribution conventions that need to be resolved before merging.Issues found:
docker-compose.ymlline 1): Must be"3.8", not"3.3".container_namemust be removed (docker-compose.ymlline 6): Dokploy manages container naming; explicit names cause conflicts.portsmust be replaced withexpose(docker-compose.ymllines 20–22): External port routing is handled by Dokploy's proxy — usingportsbypasses this.docker-compose.ymlline 4): The service is namedmasterbut must exactly match the blueprint folder namecrawlab. TheserviceNameintemplate.tomlmust be updated accordingly.template.toml(lines 11–13): The[config.env]object subtable syntax is not supported — must use an array of strings under[config].crawlabteam/crawlab:latest): Should be pinned to a specific release to prevent silent upstream changes and supply chain risk. Theversioninmeta.jsonmust then be updated to match.Confidence Score: 2/5
Not safe to merge — multiple mandatory Dokploy conventions are violated in both docker-compose.yml and template.toml.
There are four P1 violations in docker-compose.yml (wrong Compose version, forbidden container_name, forbidden ports, wrong service name) and one P1 violation in template.toml (invalid env var syntax), all explicitly required by the project AGENTS.md guide. These will result in incorrect or broken deployments.
blueprints/crawlab/docker-compose.yml and blueprints/crawlab/template.toml both need corrections before merging.
Important Files Changed
Reviews (1): Last reviewed commit: "feat: add crawlab - re order" | Re-trigger Greptile
(2/5) Greptile learns from your feedback when you react with thumbs up/down!
Context used: