Emergency Response Team & Central Command Overhaul#1130
Conversation
|
These sprites look nice, great job with them! |
00-Steven
left a comment
There was a problem hiding this comment.
left off at outfits.dm, going from bottom to top
There was a problem hiding this comment.
attribution for all these sounds being?
| /obj/item/gun/ballistic/automatic/karim/item_interaction(mob/living/user, obj/item/tool, list/modifiers) | ||
| if(underbarrel) | ||
| if(isammocasing(tool)) | ||
| var/obj/item/ammo_casing/boolet = tool | ||
| if(boolet.caliber == underbarrel.magazine.caliber) | ||
| return underbarrel.item_interaction(user, boolet, modifiers) | ||
| return ITEM_INTERACT_BLOCKING | ||
| if(istype(tool, /obj/item/ammo_box/magazine/ammo_stack)) | ||
| var/obj/item/ammo_box/magazine/ammo_stack/stack = tool | ||
| var/obj/item/casing = stack.get_round(TRUE) | ||
| if(!istype(casing, /obj/item/ammo_casing)) | ||
| return ITEM_INTERACT_BLOCKING | ||
| var/obj/item/ammo_casing/boolet = casing | ||
| if(boolet.caliber != underbarrel.magazine.caliber) | ||
| return ITEM_INTERACT_BLOCKING | ||
| return underbarrel.item_interaction(user, boolet, modifiers) | ||
| return ..() |
There was a problem hiding this comment.
in an ideal world we'd call procs specific to the interaction we actually want rather than the whole item_interaction(...) proc, but given it's base tg code we can't easily split its item_interaction(...) off into separate act procs
mostly saying this for posterity's sake
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com> Signed-off-by: dawsonkeyes <76002401+dawsonkeyes@users.noreply.github.com>
00-Steven
left a comment
There was a problem hiding this comment.
mostly nitpicks, gonna assume the outfits are good cause like they're erts
| assignment = JOB_ERT_VOID_CORPS_CORPSMAN | ||
| trim_state = "trim_voidcorps_corpsman" | ||
| sechud_icon_state = "hudvoidcorpscorpsman" | ||
| honorifics = list("Corpsman", "HM.") |
There was a problem hiding this comment.
corpsman / HM.?
what's HM stand for?
There was a problem hiding this comment.
the common abbeviation for corpsman is HM which stands for Hospitalman in naval contexts
can change it as needed to fit with the others like combat technician though
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com> Signed-off-by: dawsonkeyes <76002401+dawsonkeyes@users.noreply.github.com>
About The Pull Request
Adds several new emergency response teams and a suite of new uniforms, outfits, ID trims, and roles to better fit Doppler Shift's universe.
All clothing and weapons were sprited by me, with the exception of the Kieran pistol, which uses sprites made entirely by Paxilmaniac for Lethalstation.
There's a fair bit of mixed inspiration as well; Port Authority/Pallas Cargo and Transport outfits and the PA-RC combat armor both take heavily after other sprites.
The Port Authority Response Corps

The "catch-all" ERT for any of the crew's needs. Response Corps officers come in a nice green hat and reflective vest to make sure you know they're here to help, and their shuttle contains supplies for every occasion, from a full surgical suite & spare medical equipment to engineering tools & explosives as well as a full armory complete with space-proof equipment and some decently useful weaponry.
The Fourth Celestial Alignment Void Corps

Taking the place of /tg/station's Death Commandos, the Void Corps are one of the Fourth Celestial Alignment's dedicated military forces. They come well-suited taking on most threats with powerfully-equipped MODsuits effective at moving in a vacuum and specialized Karim pulse rifles with grenade launchers, alongside the Minhir heavy pulse rifle and Handheld Coherent Beam Cutter for cutting a hole through any solid obstacle.
Port Authority & Pallas Cargo and Transport Officials

Taking the place of Central Command inspectors and commanders, these still-green-but-less-vibrantly-green personnel have a nice array of outfits and come well-suited to demanding respect with their fancy-pants platinum ID cards.
Shocktroopers

Factionless and nameless, these troopers come in both heavy and light-armored variants, and are an ideal well-equipped force for any events that demand antagonists that aren't the Syndicate.
New Plasma Envirosuits

Three new plasma envirosuits cover both the Port Authority & Pallas Cargo and Transport representative roles, with one solid green "intern" option being available in loadouts (alongside the void corps uniform and standard PA intern uniform).
Why It's Good For The Game
Doppler's universe is very well-written, but for several years now the game hasn't fully reflected that you're not working for Nanotrasen. This doesn't fully rectify that, but it should help quite a bit and massively improve the atmosphere - no longer are PA officials hastily-renamed CentCom Commanders; they've now got a fully unique suite of things that collectively make them special.
Also I think the old CentCom plasma envirosuit sprites were super crusty.
Testing Evidence
Evidence Dropdown
Changelog
🆑 DawsonKeyes
add: Several new ERTs better suited to Doppler Shift's lore
add: A heap of new outfits, all with matching HUD icons and ID trims
add: New loadout items including the Void Corps uniform, Port Authority work outfit, and modern phorid envirosuit
fix: Fixes a bug causing revolvers reloaded from shell casing piles to have one more empty chamber than usual
/:cl: