Open
Conversation
Replace LINQ ToList().ForEach() with a standard foreach loop when appending extra attributes. This avoids an unnecessary O(N) memory allocation and improves execution speed for dictionary translation.
There was a problem hiding this comment.
Pull request overview
This PR optimizes the payload merge logic in PointerInputDevice by replacing an allocation-heavy LINQ iteration with a direct dictionary enumeration, and adds a small standalone benchmark project to compare the two approaches.
Changes:
- Replaced
ToList().ForEach(...)with aforeachloop when copying pointer extra attributes into the interaction payload. - Added a
benchmark/console project to compare the LINQ vsforeachapproaches.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Appium.Net/Appium/Interactions/PointerInputDevice.cs | Removes intermediate list allocation by iterating the attributes dictionary directly. |
| benchmark/Program.cs | Adds an ad-hoc stopwatch benchmark comparing LINQ vs foreach. |
| benchmark/benchmark.csproj | Introduces a new benchmark console project and its target framework configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace LINQ ToList().ForEach() with a standard foreach loop when appending extra attributes. This avoids an unnecessary O(N) memory allocation and improves execution speed for dictionary translation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Replaced the LINQ
ToList().ForEach(...)iteration with a standardforeachloop insidePointerInputDevice.cs.🎯 Why: The previous implementation called
ToList()on aDictionary, which creates an unnecessaryList<KeyValuePair<string, object>>allocation. Using a standardforeachloop directly iterates the dictionary's enumerator without allocating extra memory, resulting in faster execution.📊 Measured Improvement:
A focused benchmark mimicking the exact dictionary copy operation (with 100 extra attributes per iteration, tested over 100,000 iterations) yielded the following results locally:
PR created automatically by Jules for task 104955595590661477 started by @Dor-bl